Allow unicode type in given step names in Py 2 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the given step name to be unicode in Py2. Py 3 is not affected. It still does not allow non-ascii characters as they're not allowed in Py 2 `__name__`s.
youtux
approved these changes
Jul 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when migrating from Py 2 to Py 3 when using
from __future__ import unicode_literalsin your step definition files because all given steps can remain untouched.To pytest_bdd it does not matter whether the step name is a
strorunicodein Py 2, as long as the name does not contain non-ascii characters. (because it is used to set the function__name__which only allows ascii in Py 2)Py 3 is not affected by these changes.