Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest --generate --fixtures flag #319

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

jamesharris-garmin
Copy link
Contributor

@jamesharris-garmin jamesharris-garmin commented Aug 23, 2019

This patch resolves the issues where pytest will try to double load the
pytest_cmd_main.

This resolves issue #204

@jamesharris-garmin
Copy link
Contributor Author

@youtux you might find this useful.

@coveralls
Copy link

coveralls commented Aug 23, 2019

Coverage Status

Coverage remained the same at 96.114% when pulling 2d4485e on jamesharris-garmin:fix-generation-command into 386ed90 on pytest-dev:master.

@youtux
Copy link
Contributor

youtux commented Aug 23, 2019

Thanks for the fix. Can you also add these 2 lines at the end of test_generate_missing so that we cover it for the future?

assert not result.stderr.str()
assert result.ret == 0

This patch resolves the issues where pytest will try to double load the
pytest_cmd_main.
@jamesharris-garmin
Copy link
Contributor Author

Done and done!

@youtux youtux merged commit b95e8e3 into pytest-dev:master Aug 23, 2019
@youtux
Copy link
Contributor

youtux commented Aug 23, 2019

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants