Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous step funcs #536

Merged
merged 4 commits into from Jul 15, 2022
Merged

Anonymous step funcs #536

merged 4 commits into from Jul 15, 2022

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Jul 10, 2022

Use _ as the step function name for all steps. It should not matter what the name is, and giving it a significant name was always a pain and useless.

This should also encourage users to not care about the step function name, but just the given/when/then names. Updated docs in #541 .

Inspired by the ward framework.

Checklist

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #536 (d73fa1e) into master (adcc48f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files          49       49           
  Lines        1685     1685           
  Branches      208      208           
=======================================
  Hits         1558     1558           
  Misses         90       90           
  Partials       37       37           
Impacted Files Coverage Δ
pytest_bdd/steps.py 96.36% <ø> (ø)
tests/args/cfparse/test_args.py 100.00% <ø> (ø)
tests/args/parse/test_args.py 100.00% <ø> (ø)
tests/args/regex/test_args.py 100.00% <ø> (ø)
tests/feature/test_alias.py 100.00% <ø> (ø)
tests/feature/test_background.py 100.00% <ø> (ø)
tests/feature/test_cucumber_json.py 92.59% <ø> (ø)
tests/feature/test_description.py 100.00% <ø> (ø)
tests/feature/test_gherkin_terminal_reporter.py 100.00% <ø> (ø)
tests/feature/test_multiline.py 100.00% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcc48f...d73fa1e. Read the comment docs.

@youtux youtux marked this pull request as draft July 10, 2022 15:43
@youtux youtux added the internal Internal work label Jul 12, 2022
@youtux youtux marked this pull request as ready for review July 15, 2022 16:38
@youtux youtux merged commit c0357d5 into master Jul 15, 2022
@youtux youtux deleted the anonymous-step-funcs branch July 15, 2022 17:12
pbarnajc pushed a commit to pbarnajc/pytest-bdd that referenced this pull request Jan 31, 2023
pbarnajc pushed a commit to pbarnajc/pytest-bdd that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant