Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async steps #609

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Async steps #609

wants to merge 2 commits into from

Commits on Apr 16, 2023

  1. Fix tests/feature/test_cucumber_json.py::test_step_trace 

    This test was failing when run as part of the entire test suite and
passing when run on its own. When the first part of the  expected[0].id
path was changed from test_step_trace0 to test_step_trace1, the results
reversed - it passed as part of the entire suite and failed on its own.
This behavior was not observed prior to the async changed.

I suspect that this is caused by the addition of
test_async_steps.py::test_step_trace, which caused this to no longer
be the first test with the name `test_step_trace` to run as part of the
entire suite. Since there are several other tests with the same name,
it seems like the best course here would be to ensure that this test
has a unique name so that it is more resilient to ordering.
    @maafy6
    maafy6 committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    8fd0fd5 View commit details
    Browse the repository at this point in the history

  2. Implement async steps.

    @maafy6
    maafy6 committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    c292b9a View commit details
    Browse the repository at this point in the history