Fix regression described in #348 - not all reports returning the total.

pytest-dev · Oct 5, 2019 · 5ef4767 · 5ef4767
1 parent 5df26bd
commit 5ef4767
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/pytest_cov/engine.py b/src/pytest_cov/engine.py
@@ -155,14 +155,14 @@ def summary(self, stream):
         if 'html' in self.cov_report:
             output = self.cov_report['html']
             with _backup(self.cov, "config"):
-                self.cov.html_report(ignore_errors=True, directory=output)
+                total = self.cov.html_report(ignore_errors=True, directory=output)
             stream.write('Coverage HTML written to dir %s\n' % (self.cov.config.html_dir if output is None else output))
 
         # Produce xml report if wanted.
         if 'xml' in self.cov_report:
             output = self.cov_report['xml']
             with _backup(self.cov, "config"):
-                self.cov.xml_report(ignore_errors=True, outfile=output)
+                total = self.cov.xml_report(ignore_errors=True, outfile=output)
             stream.write('Coverage XML written to file %s\n' % (self.cov.config.xml_output if output is None else output))
 
         return total

diff --git a/tests/test_pytest_cov.py b/tests/test_pytest_cov.py
@@ -396,7 +396,8 @@ def test_cov_min_50(testdir):
 
     result = testdir.runpytest('-v',
                                '--cov=%s' % script.dirpath(),
-                               '--cov-report=term-missing',
+                               '--cov-report=html',
+                               '--cov-report=xml',
                                '--cov-fail-under=50',
                                script)