Always set reset_sequences on the test class according to the given…

… value This way Django will warn about any misuses and we don't rely on defaults.
pytest-dev · Nov 28, 2021 · 8433d5b · 8433d5b
1 parent 3a7ed7a
commit 8433d5b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pytest_django/fixtures.py b/pytest_django/fixtures.py
@@ -178,8 +178,7 @@ def _django_db_helper(
     _databases = databases
 
     class PytestDjangoTestCase(test_case_class):  # type: ignore[misc,valid-type]
-        if transactional and _reset_sequences:
-            reset_sequences = True
+        reset_sequences = _reset_sequences
         if _databases is not None:
             databases = _databases
 

diff --git a/tests/test_database.py b/tests/test_database.py
@@ -219,7 +219,7 @@ def test_reset_sequences_disabled(self, request) -> None:
         marker = request.node.get_closest_marker("django_db")
         assert not marker.kwargs
 
-    @pytest.mark.django_db(reset_sequences=True)
+    @pytest.mark.django_db(transaction=True, reset_sequences=True)
     def test_reset_sequences_enabled(self, request) -> None:
         marker = request.node.get_closest_marker("django_db")
         assert marker.kwargs["reset_sequences"]