Improve django_db_blocker #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blueyed I am happy to let pytest-django 3.0 out as soon as this is merged. Let me know if you want to change anything. When you are happy with this PR I'll make a release and then go and close a lot of old issues related to the new database fixtures. :) |
Also, make both block() and unblock() be context managers and remove the implicit context manager of django_db_blocker itself. Fixes pytest-dev#372.
|
Awesome! 👍 |
mfa
pushed a commit
to aexeagmbh/pytest-django
that referenced
this pull request
May 17, 2017
* Move BaseDatabaseWrapper import check to compat * Use block()/unblock() as method names in django_db_blocker. * Make both block() and unblock() be context managers and remove the implicit context manager of django_db_blocker itself. Fixes pytest-dev#372.
timb07
pushed a commit
to timb07/pytest-django
that referenced
this pull request
May 26, 2018
* Move BaseDatabaseWrapper import check to compat * Use block()/unblock() as method names in django_db_blocker. * Make both block() and unblock() be context managers and remove the implicit context manager of django_db_blocker itself. Fixes pytest-dev#372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blueyed thoughts? :)