_django_clear_outbox should clear mail.outbox instead of creating new list #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
approved these changes
Oct 25, 2016
…e misbehavior of there are others referencing mail.outbox... suddely they don't get mails to their mailbox...
…sure that mail.outbox has been created
peterlauri
force-pushed
the
clear_mailbox_should_not_create_new_list
branch
from
2d4959d
to
a72922d
Compare
|
Thanks! :) |
mfa
pushed a commit
to aexeagmbh/pytest-django
that referenced
this pull request
May 17, 2017
timb07
pushed a commit
to timb07/pytest-django
that referenced
this pull request
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _django_clear_outbox fixture creates a new list, not clearing the existing mailbox. This can cause problems as fixture execution order cannot be guaranteed, and there might be fixtures (in my case an mailoutbox fixture) that just contains a reference to mail.outbox to be able to check what emails was sent out by the system... however, tests fails randomly as sometimes my own fixture actually gets reference to an old mailbox, not the newly created one...