Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not tear down database when run with --reuse-db. Fixes #411 #476

Closed
wants to merge 2 commits into from
Closed

Do not tear down database when run with --reuse-db. Fixes #411 #476

wants to merge 2 commits into from

Conversation

dekkers
Copy link

@dekkers dekkers commented Apr 25, 2017

This will only teardown the database when --reuse-db is not used. It restores the behaviour from before the database fixture refactor and will make it possible to reuse a database with initial test data.

This will only teardown the database when --reuse-db is not used. It
restores the behaviour from before the database fixture refactor and
will make it possible to reuse a database with initial test data.
@blueyed
Copy link
Contributor

blueyed commented May 16, 2017

@dekkers
Can you add a test for this, please?
Let us know if you need help with that.

@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #476 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          32       32           
  Lines        1614     1614           
  Branches      140      140           
=======================================
  Hits         1384     1384           
  Misses        177      177           
  Partials       53       53
Flag Coverage Δ
#django110 81.72% <0%> (ø) ⬆️
#django111 83.45% <0%> (ø) ⬆️
#django17 79.61% <0%> (ø) ⬆️
#django18 80.79% <0%> (ø) ⬆️
#django19 79.86% <0%> (ø) ⬆️
#mysql_innodb 78.99% <0%> (ø) ⬆️
#mysql_myisam 78.93% <0%> (ø) ⬆️
#postgres 81.22% <0%> (ø) ⬆️
#py27 83.02% <0%> (ø) ⬆️
#py34 80.91% <0%> (ø) ⬆️
#py35 79.12% <0%> (ø) ⬆️
#py36 80.91% <0%> (ø) ⬆️
#pypy 81.59% <0%> (ø) ⬆️
#pypy3 80.79% <0%> (ø) ⬆️
#pytest3 85.74% <0%> (ø) ⬆️
#sqlite 81.59% <0%> (ø) ⬆️
#sqlite_file 80.29% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pytest_django/fixtures.py 83.54% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781daae...57e61d0. Read the comment docs.

@blueyed
Copy link
Contributor

blueyed commented Dec 25, 2017

Closing in favor of #560.

@blueyed blueyed closed this Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants