Allow setting the live server port.

[dtomas]

As the possibility to define a fixed live server port has been added back in Django 1.11.2 (https://code.djangoproject.com/ticket/28212), I'd like to have it available in pytest-django as well.

[codecov-io]

Codecov Report

Merging #500 into master will increase coverage by 0.01%.
The diff coverage is 95%.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage      92%   92.02%   +0.01%     
==========================================
  Files          33       33              
  Lines        1627     1643      +16     
  Branches      140      142       +2     
==========================================
+ Hits         1497     1512      +15     
  Misses         93       93              
- Partials       37       38       +1

Flag	Coverage Δ
#dj110	84.05% <10%> (-1.08%)	⬇️
#dj111	86.12% <95%> (-2.51%)	⬇️
#dj18	84.9% <10%> (-0.72%)	⬇️
#dj19	83.93% <10%> (-0.89%)	⬇️
#dj20	84.35% <95%> (+0.03%)	⬆️
#djmaster	84.35% <95%> (+0.03%)	⬆️
#mysql_innodb	84.35% <95%> (+0.09%)	⬆️
#mysql_myisam	84.29% <95%> (+0.09%)	⬆️
#postgres	87.64% <95%> (-0.01%)	⬇️
#py27	89.4% <95%> (+0.04%)	⬆️
#py34	83.93% <10%> (-0.89%)	⬇️
#py35	84.05% <10%> (-0.71%)	⬇️
#py36	84.84% <95%> (+0.39%)	⬆️
#pypy	?
#pypy3	?
#sqlite	86.12% <95%> (+0.01%)	⬆️
#sqlite_file	83.93% <10%> (-0.15%)	⬇️

Impacted Files	Coverage Δ
pytest_django/live_server_helper.py	91.04% <100%> (+0.56%)	⬆️
tests/test_fixtures.py	100% <100%> (ø)	⬆️
pytest_django/fixtures.py	96.81% <80%> (-0.59%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b508de...b4d0690. Read the comment docs.

[blueyed]

Thanks!

Can you cover your patch with tests, please?
See https://codecov.io/gh/pytest-dev/pytest-django/compare/781daae764e4e083eee6be111c2f0ea138aa8cf3...a725d1e9e1e817a8f63419ae7e6f6b31befc91b1/diff.

[dtomas]

My changes in fixtures.py should already be covered by test_fixtures.py. I'm not sure why they are shown as not covered, as most of the test code (except the one for versions 1.11.0 up to 1.11.2) seems to have been run.
I'm surprised that fixtures.py:314 onwards has not been executed while at the same time test_specified_port_range_error_message_django_111() seems to have been run and passed.
I might be misreading the codecov output though, not having worked with it before.

[blueyed]

You are right, there seems to be an issue with the coverage reporting.

Please rebase it on master and force-push - let's see if that fixes it.

[blueyed]

I think #537 should have fixed this.
Re-triggering a build to get codecov report.

[blueyed]

Coverage report seems to be correct now, but it shows that we do not test the non-current Django 1.11 (< 1.11.2 IIRC).
Maybe we should not support this after all, and remove the code regarding it? /cc @pelme

[avacore1337]

This patch solves our problems with testing our django REST framework application with selenium. Our Angular frontend doesn't really know what port to connect to otherwise. So thank you ^^

[blueyed]

Thank you!