Ensure that the LICENSE file is included in wheels #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 94.38% 94.38%
=======================================
Files 33 33
Lines 1834 1834
Branches 156 156
=======================================
Hits 1731 1731
Misses 78 78
Partials 25 25
Continue to review full report at Codecov.
|
|
Thanks! |
blueyed
reviewed
Oct 27, 2018
| @@ -19,3 +19,6 @@ exclude = lib/,src/,docs/,bin/ | |||
| [isort] | |||
| # NOTE: local imports are handled special (they do not get handled as "tests"). | |||
| forced_separate=tests,pytest_django,pytest_django_test | |||
|
|
|||
| [metadata] | |||
| license_file=LICENSE | |||
There was a problem hiding this comment.
@pombredanne
Can you comment on #653, please? Does it make sense to remove the manifest?
There was a problem hiding this comment.
@blueyed sure thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com