Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning use of getfuncargvalue is deprecated, use getfixturevalue #62

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

sliverc
Copy link
Contributor

@sliverc sliverc commented Apr 9, 2018

Fixes #68

getfixturevalue already exists since pytest version 3.0.0


This change is Reviewable

getfixturevalue already exists since pytest version 3.0
@bullfest
Copy link

@blueyed It would be nice if this could be merged, is there something else that needs to be done that one could help out with?

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but won't merge it myself.

@Marpop
Copy link

Marpop commented Sep 17, 2018

is this associated with issue #68?

@sliverc
Copy link
Contributor Author

sliverc commented Sep 17, 2018

@Marpop True. Added is as reference to description of PR.

@blueyed blueyed merged commit f170b39 into pytest-dev:master Sep 17, 2018
@blueyed
Copy link
Contributor

blueyed commented Sep 17, 2018

Thanks!

@sliverc sliverc deleted the fix_deprecation_warnings branch September 18, 2018 06:37
@svirpridon
Copy link

Any plans on when this will get cut into a release and pushed to pypi?

@Timvde Timvde mentioned this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: use of getfuncargvalue is deprecated, use getfixturevalue
6 participants