Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original test cases order kept #512

Closed

Conversation

sygutss
Copy link

@sygutss sygutss commented Apr 21, 2022

Because that sometimes somebody
could want to have a possibility to
keep the original order of test cases
in the report, that possibility was
added. The logic is control by specific
flag in config file.

  1. Added necessary option flag in config.
  2. Added necessary logic if flag is set to True.
  3. Added necessary tests for new logic.
  4. Added additional section in documentation
    which describes how to turn on the new behaviour.

@sygutss
Copy link
Author

sygutss commented Apr 21, 2022

[Question]
Because of the fact that right now there is a problem with the current black version (Linters are failed) Should I also provide a fix for that under that PR? The latest version of black works fine and all pre-commit checks with all tests are passed.

@BeyondEvil
Copy link
Contributor

Thanks for the PR. 🙏

I'll fix black. 👍

@BeyondEvil
Copy link
Contributor

Try rebasing with master now.

Because that sometimes somebody
could want to have a possibility to
keep the original order of test cases
in the report, that possibility was
added. The logic is control by specific
flag in config file.

1. Added necessary option flag in config.
2. Added necessary logic if flag is set to True.
3. Added necessary tests for new logic.
4. Added additional section in documentation
which describes how to turn on the new behaviour.
1. Code formatting fixes via black
@sygutss sygutss force-pushed the feature/original_test_cases_order branch from d4b1f29 to 840af35 Compare April 22, 2022 09:05
@sygutss
Copy link
Author

sygutss commented Apr 22, 2022

Rebased and code formatting fixes made by black

@sygutss sygutss closed this Apr 25, 2022
@sygutss sygutss reopened this Apr 25, 2022
@sygutss
Copy link
Author

sygutss commented Apr 25, 2022

See that tests for py37-windows failed, dunno why... Can we re-run those checks? I closed and re-opened the pull request, probably checks start is waiting for some approval.

@BeyondEvil
Copy link
Contributor

And now it failed for py38-windows.

I might just add re-run flaky for windows.

@zwibldog
Copy link

zwibldog commented Feb 2, 2023

Hi guys,

this feature looks really great and is exactly what I'm looking for. @sygutss @BeyondEvil any update in this PR? See any chance to merge it in near future? Thanks!

@BeyondEvil
Copy link
Contributor

As soon as 4.0.0 is GA (4.0.0rc0 out now!) I'll revisit this.

@BeyondEvil
Copy link
Contributor

@sygutss @zwibldog This should be the default behaviour in 4.0.0rc1.

Please test and report any issues. 🙏

@sygutss
Copy link
Author

sygutss commented Apr 6, 2023

Hi @BeyondEvil I've updated to 4.0.0rc1 but it's not like expected in default behavior. Behavior is like the previous approach - By default we have firstly error cases and after them passed cases. After clicking on ordering in that column (header) we can switch opposite - First passed cases after failed cases. There is a lack of the possibility to achieve the original ordering

Conclusion - the original ordering is not the default behavior.

@BeyondEvil
Copy link
Contributor

Ok, thanks. I think I initially misunderstood the ask.

But OK, I get what you want now.

This happens to coincide with #521

So I'll see if I can add a query param to set initial sort order (column, asc/desc, and "original" or something).

@BeyondEvil
Copy link
Contributor

Check out #637 and #634

They will be part of the 4.0.0rc2 release coming soon.

@BeyondEvil
Copy link
Contributor

Please try 4.0.0rc4. setting query param ”sort” to ”original” will now sort in execution order.

@sygutss
Copy link
Author

sygutss commented Apr 11, 2023

Hi @BeyondEvil - I've tested it - in version 4.0.0rc4 and setting query param ”sort” to ”original” the ordering is as expected :)

Additional question - will be possible to enforce that behavior as a default one? eg. from the config file? I mean to always open by default the result html file with that ordering without a necessity to setting different ordering by query param manually?

@sygutss
Copy link
Author

sygutss commented May 14, 2023

@BeyondEvil - Up for the previous question and also when is expected to roll out the official version?

@BeyondEvil
Copy link
Contributor

Sorry for the delay. This can be set using addopts and/or ini. And v4 is out.

Thanks! 🙏

@BeyondEvil BeyondEvil closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants