Add a note about how to handle modal dialogs. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
requested changes
Mar 13, 2018
docs/note_dialogs.rst
Outdated
|
|
||
| .. code-block:: python | ||
|
|
||
| def test_Qt(qtbot, mock): |
There was a problem hiding this comment.
This should be called mocker, mock is just a compatibility alias: pytest-dev/pytest-mock#4
However, why require another plugin just for a doc example anyways? I think it'd be better to just use the built-in monkeypatch.
docs/note_dialogs.rst
Outdated
|
|
||
| .. code-block:: python | ||
|
|
||
| def test_form_registration(qtbot, mock): |
There was a problem hiding this comment.
Same as above regarding mock.
|
Thanks a lot @HazenBabcock! I agree with @The-Compiler's comments so I went ahead and applied the changes myself. Thanks again for submitting the PR, we appreciate it. 👍 |
|
Fixes #19 |
|
Great, thanks for the help with this PR. |
|
@The-Compiler are you OK with merging this? 😁 (failures are unrelated and I plan to tackle them in #202) |
|
Pushed a commit to remove the last sentence as it's not true anymore. LGTM now! 👍 |
The-Compiler
approved these changes
Mar 15, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This I think adds the modal dialog handling documentation you were looking for in issue #18 and issue #19.