Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to 1 rerun if number of reruns not specified #38

Closed
lexrj opened this issue Aug 10, 2016 · 4 comments
Closed

Default to 1 rerun if number of reruns not specified #38

lexrj opened this issue Aug 10, 2016 · 4 comments

Comments

@lexrj
Copy link

lexrj commented Aug 10, 2016

Instead of throwing an error when the number of reruns aren't specified, can it have a default parameter of 1?
@florianpilz
Copy link
Contributor

Hm, that would certainly be possible. But if you are using a pytest.ini, that shouldn't be an issue, right?

@lexrj
Copy link
Author

lexrj commented Aug 11, 2016

Sorry, I meant in the case of using the pytest.mark.flaky() decorator, the "reruns" parameter could have a default of 1.

@florianpilz
Copy link
Contributor

@lexrj Sorry, I did not see your response. That is actually very simple and I like your proposal. Since @sallner is taking over maintenance of the package: @sallner can you please implement the proposal?

sallner added a commit that referenced this issue Oct 28, 2016
@sallner
re #38: Use reruns=1 as default if nothing is passed to `pytest.mar…
1652fec 
…k.flaky()`
@sallner sallner mentioned this issue Oct 28, 2016
Merged
@sallner
Copy link
Member

sallner commented Nov 7, 2016

This issue was solved with #41.

@sallner sallner closed this as completed Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@florianpilz @sallner @lexrj