Add tests for PyPy 3.9 and update GitHub actions #204
Conversation
| @@ -28,6 +28,8 @@ jobs: | |||
| "3.10", | |||
| "3.11", | |||
| "pypy-3.7", | |||
| "pypy-3.8", | |||
| "pypy-3.9", | |||
There was a problem hiding this comment.
I see no need to test on multiple PyPy versions. Testing on one should be enough.
Why do you think it is necessary?
There was a problem hiding this comment.
One may consider testing on one of 3.8 and 3.9 as the most recent versions of PyPy do no longer support 3.7. https://www.pypy.org/posts/2022/12/pypy-v7311-release.html
The 3.7 test is running PyPy 7.3.9, while 3.8 and 3.9 is running 7.3.11. (Which explains the tox thing, so should be possible to get one in there as well, it was not clear how to distinguish them, but that is because it is not required...)
(I was chasing down an issue in the Matplotlib test suite when executed with PyPy, but I am now quite sure that it didn't come from here.)
So to conclude, I'd suggest testing of one of pypy-3.8 and pypy-3.9 to test with the latest version (it was not so clear to me that one should be enough when I did this). Plus then pypy-3.7 if you want to keep that.
There was a problem hiding this comment.
I'd suggest to replace pypy-3.7 with pypy-3.9 then.
There was a problem hiding this comment.
Updated actions for the lint workflow as well.
oscargus
force-pushed
the
pypyversions
branch
from
e82cf8e
to
8302683
Compare
oscargus
changed the title
oscargus
force-pushed
the
pypyversions
branch
from
8302683
to
0b7f5ad
Compare
|
Thank you for this PR. 😃 |
Not sure how to specify these for
toxthough...