Skip to content

Commit

Permalink
Use https, rather than http for API and job URLs (#165)
Browse files Browse the repository at this point in the history
* Use https, rather than http for API and job URLs
* Remove hard-coded port for Sauce Labs executor URL
* Update Sauce Labs executor URL in tests
  • Loading branch information
stephendonner authored and davehunt committed May 25, 2018
1 parent 59b45f2 commit 89f5e81
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions pytest_selenium/drivers/saucelabs.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@

class SauceLabs(Provider):

API = 'http://saucelabs.com/rest/v1/{username}/jobs/{session}'
JOB = 'http://saucelabs.com/jobs/{session}'
API = 'https://saucelabs.com/rest/v1/{username}/jobs/{session}'
JOB = 'https://saucelabs.com/jobs/{session}'

@property
def auth(self):
return self.username, self.key

@property
def executor(self):
return 'http://{0}:{1}@ondemand.saucelabs.com:80/wd/hub'.format(
return 'https://{0}:{1}@ondemand.saucelabs.com/wd/hub'.format(
self.username, self.key)

@property
Expand Down
2 changes: 1 addition & 1 deletion testing/test_saucelabs.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_auth_token(monkeypatch, auth_type, auth_token):
monkeypatch.setenv('SAUCELABS_API_KEY', 'bar')

session_id = '12345678'
url = 'http://saucelabs.com/jobs/{}'.format(session_id)
url = 'https://saucelabs.com/jobs/{}'.format(session_id)

if auth_type != 'none':
url += '?auth={}'.format(auth_token)
Expand Down

0 comments on commit 89f5e81

Please sign in to comment.