Remove unnecessary install_requires on setuptools #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the explicit runtime dependency on setuptools. None of the packages installed by setuptools seem to be used by the package. While arguably the pytest entry point might require setuptools but then the dependency belongs (and is present) in pytest, especially that a future version may use a different entry point loader.
bubenkoff
approved these changes
Sep 25, 2020
|
Hi, just got your invitation. Should I push the change straight to master then, or use the green merge button, or...? ;-) |
|
green button squash and merge
…On Fri, Sep 25, 2020 at 3:24 PM Michał Górny ***@***.***> wrote:
Hi, just got your invitation. Should I push the change straight to master
then, or use the green merge button, or...? ;-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADIJACN3J7V2BTAATP5ZD3SHSKZHANCNFSM4RZHEEKQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the explicit runtime dependency on setuptools. None
of the packages installed by setuptools seem to be used by the package.
While arguably the pytest entry point might require setuptools but then
the dependency belongs (and is present) in pytest, especially that
a future version may use a different entry point loader.
This change is