Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github review instead of Reviewable #89

Closed
pelme opened this issue Dec 14, 2016 · 2 comments
Closed

Use Github review instead of Reviewable #89

pelme opened this issue Dec 14, 2016 · 2 comments

Comments

@pelme
Copy link
Member

pelme commented Dec 14, 2016

Github's support for code reviews has improved lately: batch comments, marking as resolved/requesting changes and requiring at least one review before merges:
https://help.github.com/articles/enabling-required-reviews-for-pull-requests/

I propose that we use this and get rid of Reviewable. This makes reviews a bit easier and not having to sign in/deal with another tool.

@bubenkoff If you think this is a good idea I can change the settings and enable this. Otherwise let's close this issue and keep Reviewable. :)

@bubenkoff
Copy link
Member

bubenkoff commented Dec 14, 2016 via email

@pelme
Copy link
Member Author

pelme commented Dec 14, 2016

Great! I have enabled it and disabled Reviewable!

@pelme pelme closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants