Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest-rerunfailures for crashed nodes #650

Closed
xoviat opened this issue Apr 15, 2021 · 5 comments · Fixed by #651
Closed

pytest-rerunfailures for crashed nodes #650

xoviat opened this issue Apr 15, 2021 · 5 comments · Fixed by #651

Comments

@xoviat
Copy link
Contributor

xoviat commented Apr 15, 2021

There's a hook for crashed nodes, but it doesn't let you clean-up the test failure. I'm looking for a way to contain a crashed test and rerun it.
@xoviat
Copy link
Contributor Author

xoviat commented Apr 15, 2021

cc @RonnyPfannschmidt

@RonnyPfannschmidt
Copy link
Member

Im not going to be able to do anything about that with the next half year, potentially longer

@xoviat
Copy link
Contributor Author

xoviat commented Apr 16, 2021

By inspection, remove_node needs to be patched so as not to remove the crashitem from the pending tests. It seems that if a hook was added in remove_node that returned whether the crashitem should be rerun, then pytest-rerunfailures could take care of the rest of the logic.

@xoviat
Copy link
Contributor Author

xoviat commented Apr 16, 2021

If I submitted a PR, would you have time to review it?

@RonnyPfannschmidt
Copy link
Member

both me and others probably can, there should be a small design discussion beforehand,

@xoviat xoviat mentioned this issue Apr 17, 2021
Merged
gcf-merge-on-green bot pushed a commit to GoogleCloudPlatform/python-docs-samples that referenced this issue Aug 3, 2021
@renovate-bot
chore(deps): update dependency pytest-xdist to v2.3.0 (#6234)
09caf99 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pytest-xdist](https://togithub.com/pytest-dev/pytest-xdist) | `==2.2.1` -> `==2.3.0` | [![age](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pytest-dev/pytest-xdist</summary>

### [`v2.3.0`](https://togithub.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst#pytest-xdist-230-2021-06-16)

[Compare Source](https://togithub.com/pytest-dev/pytest-xdist/compare/v2.2.1...v2.3.0)

\===============================

## Deprecations and Removals

-   `#&#8203;654 <https://github.com/pytest-dev/pytest-xdist/issues/654>`\_: Python 3.5 is no longer supported.

## Features

-   `#&#8203;646 <https://github.com/pytest-dev/pytest-xdist/issues/646>`\_: Add `--numprocesses=logical` flag, which automatically uses the number of logical CPUs available, instead of physical CPUs with `auto`.

    This is very useful for test suites which are not CPU-bound.

-   `#&#8203;650 <https://github.com/pytest-dev/pytest-xdist/issues/650>`\_: Added new `pytest_handlecrashitem` hook to allow handling and rescheduling crashed items.

## Bug Fixes

-   `#&#8203;421 <https://github.com/pytest-dev/pytest-xdist/issues/421>`\_: Copy the parent process sys.path into local workers, to work around execnet's python -c adding the current directory to sys.path.

-   `#&#8203;638 <https://github.com/pytest-dev/pytest-xdist/issues/638>`\_: Fix issue caused by changing the branch name of the pytest repository.

## Trivial Changes

-   `#&#8203;592 <https://github.com/pytest-dev/pytest-xdist/issues/592>`\_: Replace master with controller where ever possible.

-   `#&#8203;643 <https://github.com/pytest-dev/pytest-xdist/issues/643>`\_: Use 'main' to refer to pytest default branch in tox env names.

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/python-docs-samples).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new pytest_handlecrashitem hook xoviat/pytest-xdist
2 participants
@RonnyPfannschmidt @xoviat