New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix invalid url(socketserver.py) #599

Merged

nicoddemus merged 2 commits into pytest-dev:master from yili1992:master

Sep 12, 2020

Contributor

yili1992 commented Sep 10, 2020 •

edited

Loading

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

Make sure to include reasonable tests for your change if necessary
We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:
- Name it $issue_id.$type for example 588.bugfix;
- If you don't have an issue_id change it to the PR id after creating it
- Ensure type is one of removal, feature, bugfix, vendor, doc or trivial
- Make sure to use full sentences with correct case and punctuation, for example:
```
Fix issue with non-ascii contents in doctest text files.
```

yili1992 added 2 commits

September 10, 2020 10:14


          docs: fix invalid url

e03566b


          docs: fix invalid url

03ddee6

nicoddemus approved these changes

View reviewed changes

Member

nicoddemus left a comment

Thanks!

Member

nicoddemus commented Sep 12, 2020

The failure is unrelated and should be fixed by pytest-dev/pytest#7721.

nicoddemus merged commit b51286a into pytest-dev:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment