-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.3.0 #905
Release 3.3.0 #905
Conversation
This ensures we do not have any surprises when we try to deploy, which uses the same step to generate the package.
This avoids testing twice when pushing to the main repository, once for the push, and another for a PR.
jobs: | ||
|
||
check-package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to produce the package once, using this job, and then reuse this package for all the 'test' job, but I couldn't find an easy way to ask for tox
to use a specific wheel to test (instead of building its own).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I just discovered the --installpkg
from tox run
which does exactly that.
Will try it out in a separate PR.
We had 2 hickups:
I pushed the tag manually for now, will open a separate PR attempting to fix 1). |
As commented in pytest-dev#905, an annotated tag needs a configured user.
We will also use this opportunity to test the new deploy workflow. 馃憤
(Note that now release branches must be pushed to the main repository, no longer to the forks).