Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.3.0 #905

Merged
merged 4 commits into from
May 12, 2023
Merged

Release 3.3.0 #905

merged 4 commits into from
May 12, 2023

Conversation

nicoddemus
Copy link
Member

We will also use this opportunity to test the new deploy workflow. 馃憤

(Note that now release branches must be pushed to the main repository, no longer to the forks).

This ensures we do not have any surprises when we try to deploy,
which uses the same step to generate the package.
This avoids testing twice when pushing to the main repository, once for the push, and another for a PR.
jobs:

check-package:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to produce the package once, using this job, and then reuse this package for all the 'test' job, but I couldn't find an easy way to ask for tox to use a specific wheel to test (instead of building its own).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just discovered the --installpkg from tox run which does exactly that.

Will try it out in a separate PR.

@nicoddemus nicoddemus merged commit 4d230b6 into master May 12, 2023
23 of 25 checks passed
@nicoddemus nicoddemus deleted the release-3.3.0 branch May 12, 2023 20:48
@nicoddemus
Copy link
Member Author

nicoddemus commented May 12, 2023

We had 2 hickups:

  1. It published successfully, but we failed to push the tag because of the addition of --annotate:

    Committer identity unknown
    
    *** Please tell me who you are.
    
    Run
    
      git config --global user.email "you@example.com"
      git config --global user.name "Your Name"
    
    to set your account's default identity.
    Omit --global to set the identity only in this repository.
    
  2. The 'deploy' environment did not ask for approval because I missed that configuration in the Settings, but I have fixed it now.

I pushed the tag manually for now, will open a separate PR attempting to fix 1).

nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this pull request May 12, 2023
As commented in pytest-dev#905, an annotated tag needs a configured user.
@nicoddemus nicoddemus mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants