Feat/add price slot check (In on-chain programs) #16

ali-bahjati · 2022-02-11T17:21:57Z

Adds get_current_price_status to Price struct which returns the current price status. If run on-chain with the current slot it checks whether price information has got stale or not. get_current_price uses this function to make the interface consistent.

Additional changes:

Moves test_instr for testing to common.rs (as it's used in the test for this feature) and renamed it to test_instr_exex_ok to be more clear.
Adds Borsh SerDe traits to PriceStatus as it is used for testing instructions.
Makes Ema fields public. It was required for creating testing Price object.

jayantk

see inline comment

src/lib.rs

- Introduces another Price struct which doesn't have comps (published prices) and unused fields. The reason is that we want to mutate struct (to add the check) and Price Account Data has ~3kb so copying is expensive. This creates a significantly smaller one. This naming allow us to have least impact on existing consumers. The price account data is available as price account data if a consumer needs it. - Also make Ema fields public

ali-bahjati · 2022-02-14T09:25:40Z

@jayantk @Reisen

Can you review again?
I moved the logic to get_current_status function. But let's make sure to tell people to use get_current_status and get_current_price.

Didn't change the access levels of any of the fields and everything is public. I think it's good to discuss it later.

src/lib.rs

jayantk

this change generally looks good. I had a couple comments on how to structure things so they're more general / easier for readers to understand. I think there's enough there that I'd like to look at this one more time before approving.

src/lib.rs

src/instruction.rs

tests/stale_price.rs

src/lib.rs

jayantk

LGTM, but please do address the inline comments before merging.

README.md

src/instruction.rs

src/lib.rs

tests/common.rs

ali-bahjati requested review from Reisen and jayantk February 11, 2022 17:21

jayantk reviewed Feb 11, 2022

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

ali-bahjati added 2 commits February 14, 2022 08:12

Add newline to end of files

b026932

ali-bahjati force-pushed the feat/add-price-slot-check branch from c9a3200 to b026932 Compare February 14, 2022 08:14

ali-bahjati added 2 commits February 14, 2022 09:21

Move status logic to a getter function

b12f339

Revert load_price to previous naming

aafac8c

ali-bahjati commented Feb 14, 2022

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

Rename max_sender_delay to max_slot_difference

ad2c9b9

jayantk reviewed Feb 14, 2022

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/instruction.rs Outdated Show resolved Hide resolved

tests/stale_price.rs Outdated Show resolved Hide resolved

tests/stale_price.rs Outdated Show resolved Hide resolved

Refactor & Add more comments

dbbd5d6

ali-bahjati requested a review from jayantk February 15, 2022 09:20

Add newline to files

508adb5

Reisen reviewed Feb 15, 2022

View reviewed changes

src/lib.rs Show resolved Hide resolved

jayantk approved these changes Feb 15, 2022

View reviewed changes

ali-bahjati added 6 commits February 15, 2022 15:33

Make comments and namings much better according to Jayant suggestions

b1ae955

Move Price deserialization in instruction api

b77cb07

Rename get_current_status to get_current_price_status

ffd8a89

Update readme

a49ad38

Fix formatting

2621445

Update get_accounts example

7b5dc22

ali-bahjati mentioned this pull request Feb 17, 2022

lib.rs: make Ema fields public #3

Closed

Reisen approved these changes Feb 17, 2022

View reviewed changes

ali-bahjati merged commit 210087a into main Feb 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add price slot check (In on-chain programs) #16

Feat/add price slot check (In on-chain programs) #16

ali-bahjati commented Feb 11, 2022 •

edited

jayantk left a comment

ali-bahjati commented Feb 14, 2022

jayantk left a comment

jayantk left a comment

Feat/add price slot check (In on-chain programs) #16

Feat/add price slot check (In on-chain programs) #16

Conversation

ali-bahjati commented Feb 11, 2022 • edited

jayantk left a comment

Choose a reason for hiding this comment

ali-bahjati commented Feb 14, 2022

jayantk left a comment

Choose a reason for hiding this comment

jayantk left a comment

Choose a reason for hiding this comment

ali-bahjati commented Feb 11, 2022 •

edited