Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aggregate in the same slot #394

Merged
merged 61 commits into from
Apr 16, 2024
Merged

feat: aggregate in the same slot #394

merged 61 commits into from
Apr 16, 2024

Conversation

cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Feb 21, 2024 •
edited

update aggregation logic to aggregate in the same slot, also change ema and twap to calculate on the same slot

@cctdaniel cctdaniel changed the title update aggregation logic to aggregate in the same slot feat: update aggregation logic to aggregate in the same slot Mar 11, 2024
@cctdaniel cctdaniel changed the title feat: update aggregation logic to aggregate in the same slot feat: aggregate in the same slot Mar 11, 2024
ali-bahjati
ali-bahjati previously approved these changes Apr 9, 2024
View reviewed changes
jayantk
jayantk previously approved these changes Apr 9, 2024
View reviewed changes
@cctdaniel cctdaniel dismissed stale reviews from jayantk and ali-bahjati via 5be3e09 April 10, 2024 12:32
ali-bahjati
ali-bahjati previously approved these changes Apr 10, 2024
View reviewed changes
guibescos
guibescos previously approved these changes Apr 15, 2024
View reviewed changes
@cctdaniel cctdaniel merged commit 65949e0 into main Apr 16, 2024
3 checks passed
@cctdaniel cctdaniel deleted the same-slot-agg branch April 16, 2024 07:50
ali-bahjati added a commit that referenced this pull request May 3, 2024
@ali-bahjati
Revert "feat: aggregate in the same slot (#394)"
ca0c981 
This reverts commit 65949e0.
ali-bahjati added a commit that referenced this pull request May 3, 2024
@ali-bahjati
Revert "feat: aggregate in the same slot (#394)" (#401)
ceb4a32 
This reverts commit 65949e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-bahjati ali-bahjati ali-bahjati approved these changes

@jayantk jayantk jayantk left review comments

@guibescos guibescos guibescos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cctdaniel @jayantk @ali-bahjati @guibescos