Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(LearnerND) if you stop the runner, and then try to continue, it fails. #23

Closed
basnijholt opened this issue Dec 19, 2018 · 3 comments
Closed

Comments

@basnijholt
Copy link
Member

(original issue on GitLab)

opened by Jorn Hoofwijk (@Jorn) at 2018-10-16T18:52:22.570Z

It also fails when loading in data from a pickle and then trying to continue (only noticeable in gitlab:!118) yet probably one bug causes both issues.

This can be easily captured in a test. Let's add this test for each runner

@basnijholt
Copy link
Member Author

originally posted by Bas Nijholt (@basnijholt) at 2018-10-22T13:27:25.764Z on GitLab

The current implementation actually does work just fine and is being tested.

Do you refer to the code we used last week in the presentation? Where we just set self.data = data and called self.tri?

@basnijholt
Copy link
Member Author

originally posted by Jorn Hoofwijk (@Jorn) at 2018-10-25T09:49:02.739Z on GitLab

Well actually in my memory there was this bug that simply running a learnerND, then cancelling the runner and then running the same learner with a different runner would actually make it fail...

Yet apparently I cannot reproduce it anymore.

However the thing with save and load does remain an issue of course

@basnijholt
Copy link
Member Author

originally posted by Bas Nijholt (@basnijholt) at 2018-12-07T19:33:00.597Z on GitLab

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant