Add support for neighbours in loss computation in LearnerND #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great @JornHoofwijk, I'll soon go over your new changes! 😄 |
Closed
basnijholt
pushed a commit
that referenced
this pull request
May 6, 2019
* add support for neighbours in loss computation in LearnerND * make loss function only accept one single exploration factor * redefine the call signature of the curvature loss function * make learnerND curvature loss work without errors * add function to triangulation to find opposing vertices * add some more tests for get_opposing_vertices * make use of the new api * fix spaces (after comma and indentation) * remove unused import * remove comment * add exception if too many neighbors * remove trailing whitespace
basnijholt
pushed a commit
that referenced
this pull request
May 8, 2019
* add support for neighbours in loss computation in LearnerND * make loss function only accept one single exploration factor * redefine the call signature of the curvature loss function * make learnerND curvature loss work without errors * add function to triangulation to find opposing vertices * add some more tests for get_opposing_vertices * make use of the new api * fix spaces (after comma and indentation) * remove unused import * remove comment * add exception if too many neighbors * remove trailing whitespace
basnijholt
pushed a commit
that referenced
this pull request
Jul 10, 2019
* add support for neighbours in loss computation in LearnerND * make loss function only accept one single exploration factor * redefine the call signature of the curvature loss function * make learnerND curvature loss work without errors * add function to triangulation to find opposing vertices * add some more tests for get_opposing_vertices * make use of the new api * fix spaces (after comma and indentation) * remove unused import * remove comment * add exception if too many neighbors * remove trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the LearnerND get the option to add more points in highly curved areas (similar to the Learner1D)
It also moves the
uses_nth_neighborfunction from thelearner1Dto thebase_learnerto avoid circular imports