Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to_numpy methods #317

Merged
merged 1 commit into from
Apr 7, 2021
Merged

add to_numpy methods #317

merged 1 commit into from
Apr 7, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 6, 2021

Description

After having answered "How do I get the data" 1000 times and having written the code to convert learner.data to a numpy array many times as well, I decided to just add it in Adaptive.

I have implemented it such that a single array is returned with the points and values concatenated. An alternative is to return the points and values as separate arrays.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

After having answered "How do I get the data" 1000 times, and having written the code in the new `to_numpy` many times as well, I decided to just add it in Adaptive.
Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we also add this to the documentation?

@jbweston jbweston merged commit 43ed272 into master Apr 7, 2021
@jbweston jbweston deleted the to_numpy branch April 7, 2021 15:15
@basnijholt
Copy link
Member Author

Should be in the API docs :-)

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants