Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run seperate typeguard job (because it is much slower) #350

Merged
merged 3 commits into from May 31, 2022

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt
Copy link
Member Author

Tests should pass after #348 is merged.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #350 (a4fadee) into master (a596bcd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   80.82%   80.83%           
=======================================
  Files          38       38           
  Lines        5058     5060    +2     
  Branches      946      946           
=======================================
+ Hits         4088     4090    +2     
  Misses        828      828           
  Partials      142      142           
Impacted Files Coverage Δ
adaptive/runner.py 70.31% <100.00%> (-0.51%) ⬇️
adaptive/learner/learner1D.py 90.50% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a596bcd...a4fadee. Read the comment docs.

@basnijholt basnijholt merged commit 049acdb into master May 31, 2022
@basnijholt basnijholt deleted the typeguard-job branch May 31, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants