Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HoloViews opts deprecation warnings #357

Merged
merged 1 commit into from Apr 7, 2023
Merged

Conversation

basnijholt
Copy link
Member

WARNING:param.main: Calling the .opts method with options broken down by options group (i.e. separate plot, style and norm groups) is deprecated. Use the .options method converting to the simplified format instead or use hv.opts.apply_groups for backward compatibility.

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #357 (b1d0e78) into main (6c69e88) will increase coverage by 0.07%.
The diff coverage is 65.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   78.08%   78.15%   +0.07%     
==========================================
  Files          37       38       +1     
  Lines        5525     5530       +5     
  Branches      989      989              
==========================================
+ Hits         4314     4322       +8     
+ Misses       1064     1058       -6     
- Partials      147      150       +3     
Impacted Files Coverage Δ
adaptive/tests/test_learners.py 86.86% <31.42%> (ø)
adaptive/learner/average_learner1D.py 74.75% <42.10%> (ø)
adaptive/learner/learnerND.py 59.55% <42.85%> (+0.44%) ⬆️
adaptive/utils.py 61.20% <47.27%> (ø)
adaptive/learner/base_learner.py 88.37% <50.00%> (ø)
adaptive/learner/skopt_learner.py 59.42% <50.00%> (ø)
adaptive/notebook_integration.py 18.65% <50.00%> (ø)
adaptive/learner/average_learner.py 79.33% <52.00%> (ø)
adaptive/learner/sequence_learner.py 76.10% <59.57%> (ø)
adaptive/learner/learner1D.py 87.71% <64.28%> (ø)
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nickvazz
Copy link

Would love to have this go into the next release to clean up the plots in notebooks 😄

@citterio
Copy link

holoviz/holoviews#5497 turns this warning into ValueError

@basnijholt basnijholt changed the title WIP: Fix HoloViews opts deprecation warnings Fix HoloViews opts deprecation warnings Apr 7, 2023
@basnijholt basnijholt merged commit 39196b1 into main Apr 7, 2023
6 of 21 checks passed
@basnijholt basnijholt deleted the holoviews-warnings branch April 7, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants