Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing.TypeAlias #367

Merged
merged 3 commits into from Oct 11, 2022
Merged

Use typing.TypeAlias #367

merged 3 commits into from Oct 11, 2022

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #367 (c7a7b01) into master (914495c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   80.20%   80.25%   +0.04%     
==========================================
  Files          37       37              
  Lines        5334     5342       +8     
  Branches      975      975              
==========================================
+ Hits         4278     4287       +9     
+ Misses        890      887       -3     
- Partials      166      168       +2     
Impacted Files Coverage Δ
adaptive/learner/learner1D.py 89.57% <100.00%> (+0.10%) ⬆️
adaptive/types.py 100.00% <100.00%> (ø)
adaptive/runner.py 68.60% <0.00%> (-0.69%) ⬇️
adaptive/_version.py 45.61% <0.00%> (+2.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt enabled auto-merge (squash) October 11, 2022 02:41
@basnijholt basnijholt merged commit 50fae43 into master Oct 11, 2022
@basnijholt basnijholt deleted the type-alias branch October 11, 2022 03:02
basnijholt added a commit that referenced this pull request Apr 7, 2023
* Use typing.TypeAlias

* Optionally install typing_extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants