Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type-hints to Learner2D #375

Merged
merged 1 commit into from Oct 12, 2022
Merged

Add type-hints to Learner2D #375

merged 1 commit into from Oct 12, 2022

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Add type-hints to adaptive/learner/learner2D.py Add type-hints to Learner2D Oct 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #375 (ab976a9) into main (8fd6de5) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   77.69%   77.65%   -0.05%     
==========================================
  Files          37       37              
  Lines        5420     5423       +3     
  Branches      982      982              
==========================================
  Hits         4211     4211              
- Misses       1062     1064       +2     
- Partials      147      148       +1     
Impacted Files Coverage Δ
adaptive/tests/test_pickling.py 88.67% <ø> (ø)
adaptive/learner/learner2D.py 76.52% <100.00%> (+0.22%) ⬆️
adaptive/tests/test_runner.py 86.25% <100.00%> (ø)
adaptive/learner/learner1D.py 86.73% <0.00%> (-0.99%) ⬇️
adaptive/tests/test_cquad.py 92.25% <0.00%> (+0.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt force-pushed the type-hint-learner2D branch 3 times, most recently from 95a3da1 to ef0dbf7 Compare October 12, 2022 22:02
@basnijholt basnijholt enabled auto-merge (squash) October 12, 2022 22:07
@basnijholt basnijholt enabled auto-merge (squash) October 12, 2022 22:52
@basnijholt basnijholt mentioned this pull request Oct 12, 2022
@basnijholt basnijholt merged commit e06b34c into main Oct 12, 2022
@basnijholt basnijholt deleted the type-hint-learner2D branch October 12, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants