Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to pre-commit and fix all current typing issues #414

Merged
merged 26 commits into from Apr 29, 2023
Merged

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 29, 2023

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Add mypy Add mypy to pre-commit and fix all current typing issues Apr 29, 2023
@basnijholt basnijholt marked this pull request as ready for review April 29, 2023 04:15
@basnijholt basnijholt merged commit e0809ae into main Apr 29, 2023
13 of 21 checks passed
@basnijholt basnijholt deleted the add-mypy branch April 29, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant