Add missing collect_by_mro to typing stubs

Fixes #711
python-attrs · Nov 3, 2020 · 56c7308 · 56c7308
1 parent 48157a5
commit 56c7308
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/changelog.d/711.change.rst b/changelog.d/711.change.rst
@@ -0,0 +1 @@
+The type stubs for ``attr.s()`` and ``attr.make_class()`` are not missing the *collect_by_mro* argument anymore.
diff --git a/src/attr/__init__.pyi b/src/attr/__init__.pyi
@@ -273,6 +273,7 @@ def attrs(
     eq: Optional[bool] = ...,
     order: Optional[bool] = ...,
     auto_detect: bool = ...,
+    collect_by_mro = ...,
     getstate_setstate: Optional[bool] = ...,
     on_setattr: Optional[_OnSetAttrArgType] = ...,
     field_transformer: Optional[_FieldTransformer] = ...,
@@ -297,6 +298,7 @@ def attrs(
     eq: Optional[bool] = ...,
     order: Optional[bool] = ...,
     auto_detect: bool = ...,
+    collect_by_mro = ...,
     getstate_setstate: Optional[bool] = ...,
     on_setattr: Optional[_OnSetAttrArgType] = ...,
     field_transformer: Optional[_FieldTransformer] = ...,
@@ -386,6 +388,7 @@ def make_class(
     auto_exc: bool = ...,
     eq: Optional[bool] = ...,
     order: Optional[bool] = ...,
+    collect_by_mro = ...,
     on_setattr: Optional[_OnSetAttrArgType] = ...,
     field_transformer: Optional[_FieldTransformer] = ...,
 ) -> type: ...

diff --git a/tests/typing_example.py b/tests/typing_example.py
@@ -244,3 +244,8 @@ class NGFrozen:
 
 # XXX: needs support in mypy
 # ngf = NGFrozen(1)
+
+
+@attr.s(collect_by_mro=True)
+class MRO:
+    pass