Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a deprecation warning when evolve receives insta as a kw arg #1117

Merged
merged 10 commits into from
Apr 5, 2023

Conversation

hynek
Copy link
Member

@hynek hynek commented Apr 3, 2023

this looking ok @ikonst?

Fixes #1109

@Tinche
Copy link
Member

Tinche commented Apr 3, 2023

How bout we remove assoc? I think we're passed 2018 by now. 😇

@hynek
Copy link
Member Author

hynek commented Apr 3, 2023

I think we should change the deprecation, actually. People still use it, because it works differently. I don't remember the use-case but there was one. :-/

src/attr/_funcs.py Outdated Show resolved Hide resolved
@hynek
Copy link
Member Author

hynek commented Apr 4, 2023

How bout we remove assoc? I think we're passed 2018 by now. 😇

lol it was even you who found out: ericvsmith/dataclasses#42 (comment)

src/attr/_funcs.py Show resolved Hide resolved
src/attr/_funcs.py Show resolved Hide resolved
@hynek hynek merged commit a14e185 into main Apr 5, 2023
@hynek hynek deleted the deprecate-evolve-kw branch April 5, 2023 06:33
@hynek
Copy link
Member Author

hynek commented Apr 5, 2023

Thanks for your help @ikonst – we've smuggled a small feature in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make evolve 1st arg positional-only
3 participants