New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename convert to converter #315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 731 745 +14
Branches 152 156 +4
=====================================
+ Hits 731 745 +14
Continue to review full report at Codecov.
|
anyone? 😇 btw @RonnyPfannschmidt pretty sure pytest will have to update – I hope you have activated warnings? ;) |
docs/api.rst
Outdated
@@ -90,7 +90,7 @@ Core | |||
... class C(object): | |||
... x = attr.ib() | |||
>>> attr.fields(C).x | |||
Attribute(name='x', default=NOTHING, validator=None, repr=True, cmp=True, hash=None, init=True, convert=None, metadata=mappingproxy({}), type=None) | |||
Attribute(name='x', default=NOTHING, validator=None, repr=True, cmp=True, hash=None, init=True, convert=None, metadata=mappingproxy({}), type=None, converter=None) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the repr including both convert and converter bugs me… seems like only one should be included, no?
Yeah, done! Also I’ve added a warning if someone accesses that attribute. |
Fixes #307