Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop comparing/ordering subclasses #570

Merged
merged 2 commits into from Sep 7, 2019
Merged

Stop comparing/ordering subclasses #570

merged 2 commits into from Sep 7, 2019

Conversation

@hynek
Copy link
Member

@hynek hynek commented Sep 7, 2019

This has been deprecated for a year and was raising a warning.

Done in preparation for splitting cmp in eq/order.

@hynek hynek added this to the 19.2 milestone Sep 7, 2019
This has been deprecated for a year and was raising a warning.
@hynek hynek force-pushed the stop-comparing-subclasses branch from 1f0b459 to a25b24a Sep 7, 2019
ambv
ambv approved these changes Sep 7, 2019
Copy link
Contributor

@ambv ambv left a comment

Fix the typos. Code is good, test is good.

@hynek hynek merged commit f84f451 into master Sep 7, 2019
18 checks passed
@hynek hynek deleted the stop-comparing-subclasses branch Sep 7, 2019
@Julian
Copy link
Member

@Julian Julian commented Sep 8, 2019

More hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants