Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typing issues #581

Merged
merged 3 commits into from Sep 26, 2019
Merged

Fix some typing issues #581

merged 3 commits into from Sep 26, 2019

Conversation

euresti
Copy link
Contributor

@euresti euresti commented Sep 25, 2019

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@euresti euresti requested a review from hynek September 25, 2019 21:16
@euresti
Copy link
Contributor Author

euresti commented Sep 25, 2019

Do you want a changelog for this?

@hynek
Copy link
Member

hynek commented Sep 26, 2019

Do you want a changelog for this?

I don’t think it has any user-visible effects, does it? I think it’s fine.

Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot realistically review this but I don't want to block on it. If Ethan or someone else more familiar with typing, please pipe up. For now I'm merging it since mypy is telling me that it's an improvement. ¯\_(ツ)_/¯

@hynek hynek merged commit 08bbaab into python-attrs:master Sep 26, 2019
@euresti euresti deleted the type_issues branch February 18, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants