Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeddicts with period fields #377

Merged
merged 2 commits into from Jun 7, 2023
Merged

Fix typeddicts with period fields #377

merged 2 commits into from Jun 7, 2023

Conversation

Tinche
Copy link
Member

@Tinche Tinche commented Jun 7, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #377 (1987594) into main (d1368b2) will increase coverage by 5.51%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   88.87%   94.38%   +5.51%     
==========================================
  Files          26       26              
  Lines        2121     2121              
==========================================
+ Hits         1885     2002     +117     
+ Misses        236      119     -117     
Impacted Files Coverage Δ
src/cattrs/gen/typeddicts.py 81.94% <100.00%> (+5.83%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tinche Tinche merged commit dedd72d into main Jun 7, 2023
7 of 8 checks passed
@Tinche Tinche deleted the tin/fix-typeddict-keys branch June 7, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants