Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import typing_extensions.TypeAlias only on python < 3.11 #447

Merged
merged 2 commits into from Nov 17, 2023
Merged

Import typing_extensions.TypeAlias only on python < 3.11 #447

merged 2 commits into from Nov 17, 2023

Conversation

JWCook
Copy link
Contributor

@JWCook JWCook commented Nov 17, 2023

Fixes #446

@Tinche
Copy link
Member

Tinche commented Nov 17, 2023

Oh course there had to be something. I opened #448 before I saw this but I'll rather merge yours. Just add a history note please (can take from my PR).

@JWCook
Copy link
Contributor Author

JWCook commented Nov 17, 2023

Done!

@Tinche
Copy link
Member

Tinche commented Nov 17, 2023

Thanks! I'll merge this when tests pass and release it a couple hours if nothing else shows up.

@Tinche Tinche merged commit 25d15d6 into python-attrs:main Nov 17, 2023
1 check was pending
@JWCook JWCook deleted the typing-extensions-conditional-import branch November 17, 2023 19:54
@mtreinish mtreinish mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError with typing_extensions on cattrs v23.2 and python 3.11+
2 participants
@JWCook @Tinche