New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way of checking if the catalogs are up-to-date #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, seems like a good addition. Some comments around naming and so on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in is_identical
... :)
@akx Let me know if there is anything else that needs to be taken care of before we can merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! Could you rebase this?
Sure thing, done! |
@kjagiello Tests are unhappy 😭 |
This will hopefully do the trick! Forgot to do init. |
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.02%
==========================================
Files 23 23
Lines 4156 4190 +34
==========================================
+ Hits 3786 3818 +32
- Misses 370 372 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I was missing a way to, as a part of CI-pipeline, check if the translations files are up to date. This PRs attempts to implement it in form of a
--check
flag forpybabel update
.