-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to CLDR 28 #292
Upgrade to CLDR 28 #292
Conversation
91c76a8
to
da2de7f
Compare
Current coverage is
|
Non-default currency format lengths acquire colon-separated suffixes like units already do since 9327e08
These JSON files are easier to inspect by eye to figure out what might be going wrong. They are never used by Babel itself.
* Aside from the usual data changes, the provisional aa locale is no longer, so we can't use it for tests. Instead, ii is used (chosen by virtue of ii.xml being fairly small, i.e. probably as incomplete as aa). * ms_Latn_SG is not in use anymore either; use sr_Latn_ME instead. Closes python-babel#226 Closes python-babel#290
Nice! Although, what's wrong with Windows builds? |
I restarted the AppVeyor build, they had some kind of outage recently where builds where lost (at least we experienced that with coala), I guess it was that. |
@etanol is this good to merge when build succeeds? |
There we go, windows build finished. |
Yep, looks good. However, @akx, next time try not to mix in unrelated changes in the same pull request. In this case, the |
@etanol can you update https://github.com/python-babel/babel/wiki/CHANGES ? |
@etanol Sure, I don't put actually unrelated changes in the same PR. I feel |
This PR:
I'd love to have more behavioral tests that ensure there aren't serious regressions in behavior (for example by way of mis-parsing the XML files), but I'm not quite sure where to source the data for that for several languages. For the time, the current tests will have to do.
It would also be a great idea to compare and contrast the parser behavior to the actual spec (http://www.unicode.org/reports/tr35/tr35-39/tr35.html#Modifications and previous versions as linked therein).