Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CLDR 28 #292

Merged
merged 5 commits into from
Jan 1, 2016
Merged

Upgrade to CLDR 28 #292

merged 5 commits into from
Jan 1, 2016

Conversation

akx
Copy link
Member

@akx akx commented Dec 20, 2015

This PR:

  • Updates Babel to use CLDR 28, including some fixes for new CLDR features.
  • Includes some development convenience switches for the CLDR import scripts

I'd love to have more behavioral tests that ensure there aren't serious regressions in behavior (for example by way of mis-parsing the XML files), but I'm not quite sure where to source the data for that for several languages. For the time, the current tests will have to do.

It would also be a great idea to compare and contrast the parser behavior to the actual spec (http://www.unicode.org/reports/tr35/tr35-39/tr35.html#Modifications and previous versions as linked therein).

@codecov-io
Copy link

Current coverage is 82.89%

Merging #292 into master will decrease coverage by -0.62% as of 8e57070

@@            master    #292   diff @@
======================================
  Files           22      22       
  Stmts         3767    3770     +3
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           3146    3125    -21
  Partial          0       0       
- Missed         621     645    +24

Review entire Coverage Diff as of 8e57070

Powered by Codecov. Updated on successful CI builds.

Non-default currency format lengths acquire colon-separated suffixes like units already do since 9327e08
These JSON files are easier to inspect by eye to figure out what might be
going wrong.  They are never used by Babel itself.
* Aside from the usual data changes, the provisional aa locale is no longer,
  so we can't use it for tests. Instead, ii is used (chosen by virtue of ii.xml
  being fairly small, i.e. probably as incomplete as aa).
* ms_Latn_SG is not in use anymore either; use sr_Latn_ME instead.

Closes python-babel#226
Closes python-babel#290
@etanol
Copy link
Contributor

etanol commented Jan 1, 2016

Nice! Although, what's wrong with Windows builds?

@sils
Copy link
Member

sils commented Jan 1, 2016

I restarted the AppVeyor build, they had some kind of outage recently where builds where lost (at least we experienced that with coala), I guess it was that.

@sils
Copy link
Member

sils commented Jan 1, 2016

@etanol is this good to merge when build succeeds?

@sils
Copy link
Member

sils commented Jan 1, 2016

There we go, windows build finished.

@etanol
Copy link
Contributor

etanol commented Jan 1, 2016

Yep, looks good. However, @akx, next time try not to mix in unrelated changes in the same pull request. In this case, the --force and --dump-json are don't have much to do with CLDR 28 support.

etanol added a commit that referenced this pull request Jan 1, 2016
@etanol etanol merged commit 515d1c6 into python-babel:master Jan 1, 2016
@sils
Copy link
Member

sils commented Jan 1, 2016

@akx
Copy link
Member Author

akx commented Jan 2, 2016

@etanol Sure, I don't put actually unrelated changes in the same PR. I feel --force and --dump-json are related here, though, as I wrote them to make this development easier. :)

@akx
Copy link
Member Author

akx commented Jan 2, 2016

@sils1297 @etanol I updated the CHANGES doc :)

@akx akx deleted the cldr28 branch January 8, 2016 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants