Improved JavaScript extraction #332
Conversation
Current coverage is
|
And remove unittest boilerplate while at it
This looks fantastic. Thanks for adding further support! |
Any progress on this? I am in need of dotted names as keywords. Thanks. |
@catmeme If you feel like it, could you give the PR a quick code review pass? |
LGTM. |
Merging. (@RauliL is a colleague who I recruited to do CR.) |
124294a
into
python-babel:master
@akx, any chance you could update the pip package? We're ready to try out the new JSX extraction! |
@akx Yeah, we are waiting for this too :) |
@akx thanks for this great package. Unfortunately seems like the jsx support is not complete, it doesn't work on something like this:
is it the same for you or am I missing a config? |
@akx nevermind, I downloaded latest dev version (2.4.0-dev) and it's fixed. |
This PR improves the JavaScript message extraction system, adding support for
com.corporate.i18n.gettext
) (#148)<tag>
s (to avoid misparses) (#280)It's a refactor and superset of the previous JavaScript PRs, so:
Closes #298
Closes #310