Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved JavaScript extraction #332

Merged
merged 6 commits into from Mar 9, 2016
Merged

Improved JavaScript extraction #332

merged 6 commits into from Mar 9, 2016

Conversation

@akx
Copy link
Member

@akx akx commented Jan 18, 2016

This PR improves the JavaScript message extraction system, adding support for

  • dotted names as keywords (com.corporate.i18n.gettext) (#148)
  • tokenization of JSX/E4X <tag>s (to avoid misparses) (#280)
  • ES6 template strings in two different flavors (#329)

It's a refactor and superset of the previous JavaScript PRs, so:

Closes #298
Closes #310

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 18, 2016

Current coverage is 88.97%

Merging #332 into master will decrease coverage by -0.59% as of 2117212

@@            master    #332   diff @@
======================================
  Files           23      23       
  Stmts         3785    3800    +15
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           3390    3381     -9
  Partial          0       0       
- Missed         395     419    +24

Review entire Coverage Diff as of 2117212

Powered by Codecov. Updated on successful CI builds.

akx added 6 commits Jan 18, 2016
And remove unittest boilerplate while at it
Fixes #280
Fixes #148
@akx akx force-pushed the akx:improved-js branch from 9b1d021 to 5b09b64 Feb 7, 2016
This was referenced Feb 10, 2016
@zackargyle
Copy link

@zackargyle zackargyle commented Feb 10, 2016

This looks fantastic. Thanks for adding further support!

@catmeme
Copy link

@catmeme catmeme commented Mar 8, 2016

Any progress on this? I am in need of dotted names as keywords. Thanks.

@akx
Copy link
Member Author

@akx akx commented Mar 8, 2016

@catmeme If you feel like it, could you give the PR a quick code review pass?

@RauliL
Copy link

@RauliL RauliL commented Mar 9, 2016

LGTM.

@akx
Copy link
Member Author

@akx akx commented Mar 9, 2016

Merging. (@RauliL is a colleague who I recruited to do CR.)

akx added a commit that referenced this pull request Mar 9, 2016
Improved JavaScript extraction
@akx akx merged commit 124294a into python-babel:master Mar 9, 2016
5 of 6 checks passed
5 of 6 checks passed
review/gitmate/manual This commit needs review.
Details
codecov/patch 97.00% of diff hit (target 80.00%)
Details
codecov/project 88.97% (offset) compared to dd467ca at 89.56%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit All is well! :)
Details
@akx akx deleted the akx:improved-js branch Mar 9, 2016
@zackargyle
Copy link

@zackargyle zackargyle commented Mar 31, 2016

@akx, any chance you could update the pip package? We're ready to try out the new JSX extraction!

@lyapun
Copy link

@lyapun lyapun commented Mar 31, 2016

@akx Yeah, we are waiting for this too :)

@sassanh
Copy link

@sassanh sassanh commented Jul 15, 2016

@akx thanks for this great package. Unfortunately seems like the jsx support is not complete, it doesn't work on something like this:

<input ref='login-email' placeholder={gettext('username')}/>

is it the same for you or am I missing a config?

@sassanh
Copy link

@sassanh sassanh commented Jul 15, 2016

@akx nevermind, I downloaded latest dev version (2.4.0-dev) and it's fixed.
It'd be great if you'd add make install in setup.py so that when someone installs a git commit using pip it generates locale-data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants