-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Add multi-domain support to compile_catalog command #335
Conversation
Current coverage is
|
56% patch coverage? That's not fair, just because I had to indent the whole block? 😒 |
mo_files.append(self.output_file) | ||
domains = self.domain.split() | ||
|
||
for domain in domains: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make for a cleaner patch and cleaner code if you just split def run_domain(self, domain)
into a separate fn, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, good point, will do that
@ansiwen Heh, don't worry about codecov's patch measurements. It's a cranky ol' thing sometimes. |
Some projects have their translations split up into several text domains within one package. This change adds the possibility to specify a space seperated list of domains in the configuration, like 'setup.py compile_catalog --domain="foo bar"', for instance.
Thank you @ansiwen 😻 |
Frontend: Add multi-domain support to compile_catalog command
@akx: Cool, thanks for the merge. When can I expect a release with this feature? (Since we need it for openstack.) |
@sils1297 we will wait for a regular release. |
Some projects have their translations split up into several text
domains within one package. This change adds the possibility to
specify a space seperated list of domains in the configuration, like
'setup.py compile_catalog --domain="foo bar"', for instance.