Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up official support for PyPy 3 #343

Merged
merged 5 commits into from Feb 8, 2016
Merged

Set up official support for PyPy 3 #343

merged 5 commits into from Feb 8, 2016

Conversation

@akx
Copy link
Member

@akx akx commented Feb 7, 2016

As suspected in #250, Babel runs fine on PyPy3, it's just that setup.py complains. No more!

Fixes #250

@akx
Copy link
Member Author

@akx akx commented Feb 7, 2016

Assigned @sils1297 as the original owner of #250 :)

@sils
Copy link
Member

@sils sils commented Feb 7, 2016

@akx functionally good, few nitpicks

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 7, 2016

Current coverage is 88.90%

Merging #343 into master will decrease coverage by -0.66% as of 5b0a3e3

@@            master   #343   diff @@
=====================================
  Files           23     23       
  Stmts         3785   3785       
  Branches         0      0       
  Methods          0      0       
=====================================
- Hit           3390   3365    -25
  Partial          0      0       
- Missed         395    420    +25

Review entire Coverage Diff as of 5b0a3e3

Powered by Codecov. Updated on successful CI builds.

@akx akx force-pushed the pypy3 branch 2 times, most recently from 24aa71b to b7b52e7 Feb 7, 2016
@akx akx changed the title Add detection and Travis runs for PyPy3 Set up official support for PyPy 3 Feb 7, 2016
@akx
Copy link
Member Author

@akx akx commented Feb 7, 2016

@sils1297 Took another approach here -- instead of strictly checking for versions, only the bit that might fail with unsupported versions (importing __version__) has an exception check :)

In addition, to shorten setup.py a little, I removed the dead documentation building bits.

akx added 4 commits Feb 7, 2016
With pypy3 advertising itself as py3.2, but still behaving like py3.3,
the check started to become awkward.  Plus, it seems to be nicer to
ask for forgiveness rather than permission.
It's available since Python 2.5, so it's safe for our use.
@akx
Copy link
Member Author

@akx akx commented Feb 8, 2016

@sils1297 Re not doing an explicit version check: I looked through some prominent Python libraries and it does seem it's not very common to do a version check like that. (Which, I know, isn't the strongest of arguments...)

Anyway, if we see some sort of elevated issue rate due to this change, we can always begin checking for versions more rigidly again.

@akx
Copy link
Member Author

@akx akx commented Feb 8, 2016

Merging as per comments in earlier iterations of PR.

akx added a commit that referenced this issue Feb 8, 2016
Set up official support for PyPy 3
@akx akx merged commit 556ad02 into python-babel:master Feb 8, 2016
4 of 6 checks passed
@akx akx deleted the pypy3 branch Feb 8, 2016
@pyup-bot pyup-bot mentioned this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants