Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_datetime: using 'S...S' format is incorrect #360

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Projects
None yet
4 participants
@shubh1m
Copy link
Contributor

commented Feb 29, 2016

Fixes #350

@codecov-io

This comment has been minimized.

Copy link

commented Feb 29, 2016

Current coverage is 83.36%

Merging #360 into master will not affect coverage as of 8ea75fb

@@            master    #360   diff @@
======================================
  Files           21      21       
  Stmts         3781    3781       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           3152    3152       
  Partial          0       0       
  Missed         629     629       

Review entire Coverage Diff as of 8ea75fb

Powered by Codecov. Updated on successful CI builds.

return self.format(round(float('.%s' % value), num) * 10**num, num)
""" Return fractional seconds.
Rounds the time's microseconds to the precision given by the number \

This comment has been minimized.

Copy link
@akx

akx Feb 29, 2016

Member

No need to use the backslash for line continuations in docstrings :)

This comment has been minimized.

Copy link
@shubh1m

shubh1m Feb 29, 2016

Author Contributor

@akx Ok. Got it 😄

@shubh1m

This comment has been minimized.

Copy link
Contributor Author

commented Feb 29, 2016

@akx TravisCI is failing for pypy for Linux. Why so?

@akx

This comment has been minimized.

Copy link
Member

commented Feb 29, 2016

@iamshubh22 Ah, nothing to worry about if I'm guessing right. I restarted that particular build now.

To be exact, the problem is that occasionally (very seldom though) time manages to roll over a second during a test, so when a test expects a file to say the time right now (whatever it is), it may be the time right now + 1 second, and that makes the test fail.

EDIT: Yep, it was one of those bugs. :D

@codecov-io

This comment has been minimized.

Copy link

commented Feb 29, 2016

Current coverage is 89.66%

Merging #360 into master will not affect coverage as of e7ce047

@@            master    #360   diff @@
======================================
  Files           23      23       
  Stmts         3794    3794       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           3402    3402       
  Partial          0       0       
  Missed         392     392       

Review entire Coverage Diff as of e7ce047

Powered by Codecov. Updated on successful CI builds.

@akx

This comment has been minimized.

Copy link
Member

commented Feb 29, 2016

This looks good!

Thank you for the patch, @iamshubh22! 🏆

akx added a commit that referenced this pull request Feb 29, 2016

Merge pull request #360 from iamshubh22/master
format_datetime: using 'S...S' format is incorrect

@akx akx merged commit ee0e0c1 into python-babel:master Feb 29, 2016

3 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
review/gitmate/commit GitMate is currently running the analysis for this commit.
Details
review/gitmate/manual This commit needs review.
Details
codecov/patch 100.00% of diff hit (target 80.00%)
Details
codecov/project 89.66% remains the same compared to e1ce012
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@shubh1m

This comment has been minimized.

Copy link
Contributor Author

commented Feb 29, 2016

@akx Just one doubt. What does the Code coverage tells??

@akx

This comment has been minimized.

Copy link
Member

commented Feb 29, 2016

@iamshubh22:

  • codecov/patch - 100.00% of diff hit (target 80.00%)
    • This means that all of the lines of code you've touched in the PR are also being tested.
  • codecov/project - 89.66% remains the same compared to e1ce012
    • This means that coverage doesn't change -- as is reasonable. The previous version was 2 lines of code, the new version is 2 lines of code too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.