/babel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI command usage regressions #386

Merged
merged 5 commits into from Apr 12, 2016

Conversation

Reviewers
No reviews
Assignees

@jtwang jtwang

Labels
bug
Projects
None yet
Milestone
No milestone
5 participants
@akx @codecov-io @ENuge @jtwang @sebdiem
@akx
Member

akx commented Apr 11, 2016

This fixes #384 and includes @sebdiem 's patch from #383 (which fixes #385 too).

@akx akx assigned jtwang Apr 11, 2016

@akx akx added the bug label Apr 11, 2016

@akx akx referenced this pull request Apr 11, 2016

Closed

Strange new syntax for update --no-fuzzy-matching #385

@codecov-io

This comment has been minimized.

Sign in to view

codecov-io commented Apr 11, 2016

Current coverage is 90.08%

Merging #386 into master will increase coverage by +0.11% as of ce8e2c7

@@            master    #386   diff @@
======================================
  Files           24      24       
  Stmts         3931    3935     +4
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3537    3545     +8
  Partial          0       0       
+ Missed         394     390     -4

Review entire Coverage Diff as of ce8e2c7

Powered by Codecov. Updated on successful CI builds.

@akx akx referenced this pull request Apr 11, 2016

Closed

fix typos in messages frontend #383

babel/messages/frontend.py
@@ -248,12 +248,12 @@ class extract_messages(Command):
'set project version in output'),
('add-comments=', 'c',
'place comment block with TAG (or those preceding keyword lines) in '
'output file. Separate multiple TAGs with commas(,)'),
'output file. Separate multiple TAGs with commas(,)'), # TODO: Support repetition of this argument

This comment has been minimized.

Sign in to view
Copy link
@ENuge

ENuge Apr 11, 2016

Contributor

Not strictly necessary, but I'm a fan of linking these to issue numbers, like TODO(#386): or something.

This comment has been minimized.

Sign in to view
Copy link
@akx

akx Apr 12, 2016

Member

Refs are visible in the Git commit messages too, so not going to bother adding issue id this time :)
babel/messages/frontend.py Outdated
self.keywords = keywords
if not self.keywords:
raise DistutilsOptionError('no keywords specified')

This comment has been minimized.

Sign in to view
Copy link
@ENuge

ENuge Apr 11, 2016

Contributor

I think the old error message ('you must specify new keywords if you disable the default ones') was more descriptive, given that's the only time this will happen.

sebdiem and others added some commits Apr 8, 2016

@sebdiem @akx
fix typos in messages frontend 
The 'no-wrap', 'ignore-obsolete', 'no-fuzzy-matching', 'previous' and
'update-header-comment' were not correctly parsed in the update_catalog
command.
3e67c99
@akx
Make the CLI extraction command support multiple `-k`s again 
Fixes #384 (#384)

Thanks to @ajaeger for the bug report.
bfe4ab8
@akx
Refactor out `configure_cli_command`
fbc1648
@akx
Test that `update` actually accepts those boolean parameters
Loading status checks…
4795c86

@akx akx force-pushed the akx:fix-384 branch from 34ae683 to 4795c86 Apr 12, 2016

@akx akx merged commit bec1151 into python-babel:master Apr 12, 2016
4 checks passed

4 checks passed

codecov/patch 100.00% of diff hit (target 80.00%)
Details
codecov/project 90.08% (+0.11%) compared to 74f2313 at 89.97%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akx akx deleted the akx:fix-384 branch Apr 12, 2016

tests/messages/test_frontend.py
if split: # Generate a command line with multiple -ks
kwarg_text = " ".join("-k %s" % kwarg_spec for kwarg_spec in kwarg_specs)
else: # Generate a single space-separated -k
kwarg_text = "-k \"%s\"" % " ".join(kwarg_specs)

This comment has been minimized.

Sign in to view
Copy link
@ENuge

ENuge Apr 12, 2016

Contributor

I think it's cleaner to use single quotes (') for the outer string to avoid needing to escape the inner double quote ("), but up to you.

This comment has been minimized.

Sign in to view
Copy link
@akx

akx Apr 12, 2016

Member

Haha, honestly using double quotes is a habit I've learned both from writing C and from the fact that the double quote is easier to write on a Finnish keyboard than the single quote: Shift+2 vs. a separate key right next to Enter :)

But yeah, could've just as well used single quotes there!

@akx akx referenced this pull request Apr 22, 2016

Merged

2.3.4 #394

clrpackages pushed a commit to clearlinux-pkgs/Babel that referenced this pull request Jul 12, 2016

@fenrus75 clrbuilder
Babel: Autospec creation for update from version 2.3.2 to version 2.3.3 
Version 2.3.3
-------------

(Bugfix release, released on April 12th)

Bugfixes
~~~~~~~~

* CLI: Usage regressions that had snuck in between 2.2 and 2.3 should be no more. (python-babel/babel#386) Thanks to @ajaeger, @sebdiem and @jcristovao for bug reports and patches.
d752633

@pyup-bot pyup-bot referenced this pull request Apr 11, 2017

Open

Initial Update #3

@pyup-bot pyup-bot referenced this pull request Apr 27, 2017

Open

Pin babel to latest version 2.4.0 #24

@pyup-bot pyup-bot referenced this pull request May 12, 2017

Closed

Initial Update #43

@pyup-bot pyup-bot referenced this pull request Jul 4, 2017

Merged

Initial Update #2

This was referenced Aug 17, 2017

Merged
Open

This was referenced Aug 26, 2017

Merged
Closed

This was referenced Sep 4, 2017

Merged
Open

@pyup-bot pyup-bot referenced this pull request Sep 14, 2017

Open

Pin babel to latest version 2.5.1 #56

This was referenced Oct 12, 2017

Merged
Closed

@pyup-bot pyup-bot referenced this pull request Nov 3, 2017

Closed

Update babel to 2.5.1 #424

This was referenced Jan 10, 2018

Closed
Closed
Open
Closed
Open

@pyup-bot pyup-bot referenced this pull request Feb 25, 2018

Merged

Pin babel to latest version 2.5.3 #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment