Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "import_cldr: if lxml is installed, use it" #393

Merged
merged 1 commit into from Apr 19, 2016

Conversation

Projects
None yet
5 participants
@jtwang
Copy link
Contributor

commented Apr 19, 2016

This reverts commit 9b5c7f3.

Addresses #391, not much else to say. :) FYI @aronbierbaum

@akx

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

Agh, @jtwang, can you do git commit --amend --no-edit and re-force-push to restart builds?

AppVeyor's panties got in a random network bunch and I can't merge this without CI passing :D

@aronbierbaum

This comment has been minimized.

Copy link

commented Apr 19, 2016

Thank you for addressing this so quickly.

If you wanted to continue using lxml you might be able to do something like:

parse = lxml.etree.XMLParser(remove_comments = True).parse

@jtwang jtwang force-pushed the jtwang:391_jtwang_revert_lxml_optimization branch from ebc05ac to 670a84e Apr 19, 2016

@jtwang

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2016

@akx force pushed

yoda force push

@aronbierbaum - Thanks for poking at the problem! Since Aarni is OK with nuking his addition, I'm going to stick with removing lxml entirely in the interests for KISS. :)

@codecov-io

This comment has been minimized.

Copy link

commented Apr 19, 2016

Current coverage is 90.08%

Merging #393 into master will not affect coverage as of 4845ef1

@@            master    #393   diff @@
======================================
  Files           24      24       
  Stmts         3935    3935       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           3545    3545       
  Partial          0       0       
  Missed         390     390       

Review entire Coverage Diff as of 4845ef1

Powered by Codecov. Updated on successful CI builds.

@akx akx merged commit 95c86d5 into python-babel:master Apr 19, 2016

6 of 7 checks passed

review/gitmate/manual This commit needs review.
Details
codecov/patch coverage not affected
Details
codecov/project 90.08% remains the same compared to bec1151
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@akx akx referenced this pull request Apr 22, 2016

Merged

2.3.4 #394

@pyup-bot pyup-bot referenced this pull request Apr 11, 2017

Open

Initial Update #3

@pyup-bot pyup-bot referenced this pull request May 12, 2017

Closed

Initial Update #43

@pyup-bot pyup-bot referenced this pull request Jul 4, 2017

Merged

Initial Update #2

@pyup-bot pyup-bot referenced this pull request Oct 17, 2017

Closed

Initial Update #373

@pyup-bot pyup-bot referenced this pull request Nov 3, 2017

Closed

Update babel to 2.5.1 #424

@pyup-bot pyup-bot referenced this pull request Jan 10, 2018

Closed

Update babel to 2.5.1 #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.