added logfiltering feature #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapted usage doc
|
Dupe #321 |
|
my code supports excluding :P |
|
ported to tailmanager |
|
Looks good, I'll try make some time to run it locally this week. When you get chance can you add some tests around the feature too, please. |
|
Ping @pnebert any chance of adding those tests into the PR? |
|
im on it, but first i have to figure out how i run tests |
|
@JamieCressey would be maybe a good idea if you could add instructions on running tests to the readme/docs :) |
|
would be great :-) |
|
Tests are fairly straight-forward. I've taken the opportunity to add some contributing guidelines which include details on the tests: https://github.com/josegonzalez/python-beaver/blob/master/CONTRIBUTING.rst |
|
Closing due to inactivity. Feel free to reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
i added the ability to filter logs before they get shipped.
please review and hopefully merge :-)