Add many more options that can be read from the environment. Update u… #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage to mention environmental variables. Fixes python-beaver#372
|
Why weren't all the options updated? Also, this needs some form of documentation :) |
|
I left off the deprecated ones and the ones that seemed to be in the block listing command line arguments. I added a line to the usage docs indicating most config file options are also available as environmental variables, in all caps. |
|
We should have some tests for the new functionality too. Perhaps just ensure the core settings, and the settings for transports which already have tests are covered? |
|
Ping @jhmartin , will you have chance to finish off this PR? |
|
I should be able to submit the last of the env options, but my python knowledge and time isn't sufficient to add test cases for it. |
|
Closing due to inactivity. Feel free to reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add many more options that can be read from the environment. Update usage to mention environmental variables.
Fixes #372