-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZeroMq HighWaterMark socket option #98
Conversation
This needs to also be in beaver_config with a default... |
ok, i've added config entry |
@@ -14,6 +14,10 @@ def __init__(self, beaver_config, file_config, logger=None): | |||
self._ctx = zmq.Context() | |||
self._pub = self._ctx.socket(zmq.PUSH) | |||
|
|||
zeromq_hwm = beaver_config.get('zeromq_hwm') | |||
if zeromq_hwm: | |||
self._pub.hwm = int(zeromq_hwm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The int conversion should be done at https://github.com/overplumbum/beaver/blob/5933cfa69ea443b624d711679190dc0a636de2c3/beaver/config.py#L181
fixed. btw code contains other "misplaced" conversions:
|
Okay, feel free to fix the mixplaced conversions! :) |
ZeroMq HighWaterMark socket option
Merged, thanks for the pull request! |
Allows to specify zeromq_hwm socket option to prevent uncontrolled memory consumption during network failure in push mode.